Build: Test on jQuery 4.x separately to jQuery 3.x #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmethvin
approved these changes
Apr 10, 2020
Member
dmethvin
left a comment
There was a problem hiding this comment.
LGTM, you may want to add 3.5.0 here.
Having separate test runs for those jQuery lines is necessary as they support different browsers. Android 4.0 fails hard when run against jQuery master code. git.min & 3.5.0 versions were also added to aid manual testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having separate test runs for those jQuery lines is necessary as they support
different browsers. Android 4.0 fails hard when run against jQuery master code.
A git.min version was also added to aid manual testing.
I've already modified Jenkins jobs to adhere to what this PR does. I renamed the existing "jQuery Migrate" to "jQuery Migrate - 4.x core" & created a new "jQuery Migrate - 3.x core" job. Both jobs will now fire for every new Migrate commit.
I run a test run on my fork and both jobs passed:
jQuery Migrate - 4.x core: http://swarm.jquery.org/job/9632
jQuery Migrate - 3.x core: http://swarm.jquery.org/job/9633